Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth2: Make Outlook Work Again #292

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

protich
Copy link
Member

@protich protich commented Oct 28, 2024

This PR started with me trying to address cross-resource issue with Microsoft Outlook and Graph endpoints and ended up being a plugin rewrite.

Some of the changes include;

  • Making getting Resource Owner Optional - this was especially necessary for Microsoft Email provider
  • Added support for providers specifying custom Config class
  • Extend League AccessToken so we can best manage Token object e.g getting resource owner attributes
  • Added ability to decode jwt token to get resource owner info when getting resource owner is not an option
  • Updated default endpoints as needed

This commit started with me trying to address cross-resource issue with
Microsoft Outlook and Graph endpoints and ended up being a plugin
rewrite.

Some of the changes include;

* Making getting Resource Owner Optional - this was especially necessary
  for Microsoft Email provider
* Added support for providers specifying custom Config class
* Extend League AccessToken so we can best manage Token object e.g
  getting resource owner attributes
* Added ability to decode jwt token to get resource owner info when
  getting resource owner is not an option (Thanks to M$)
* Updated default endpoints as needed
When adding a new instance of MicrosoftEmailOauth2 the core validates
data using default plugin config form instead of the custom one.

This commit addresses the issue temporarily by injecting resource owner
url for validation purpose only. In the upcoming version of core we will
accept either a form or vars - making it possible to support older
plugins until end of life is reached.
auth-oauth2/oauth2.php Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants